-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added logging documentation #1519
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1519 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 509 509
Lines 30985 30985
=======================================
Hits 29683 29683
Misses 1302 1302 |
8b23503
to
d8a3176
Compare
Signed-off-by: Christian <chriamue@gmail.com>
c801299
to
e6f21ae
Compare
Whats the best location for Logging.md file? |
I think the root is probably fine for now, as others are there. We should probably put them into docs, but I think we need to do them all together. The question is where we want to put the link to this file. I think it should go into the DevReadme.md file at some useful point. @ianco -- please take a read through this for accuracy and to approve. Thanks for the contribution -- good stuff. |
Yes looks good thanks for the PR. I suggest to link from |
I would think that this section of the Developer's ReadMe would be best -- https://github.com/hyperledger/aries-cloudagent-python/blob/main/DevReadMe.md#developing |
Signed-off-by: Christian <chriamue@gmail.com>
c12ec6f
to
b35e364
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- Thanks!
Added markdown documentation of logging in Acapy.