OpenAPI demo option for no-auto and events #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when `--no-auto` option is enabled. See openwallet-foundation#361 for more details. Signed-off-by: Akiff Manji <akiff.manji@gmail.com>
Will display: Agent API requests with method, path and request body (pretty printed) Agent API responses with method, path and response body (pretty printed) Controller webhook calls with handler name and payload (pretty printed) See openwallet-foundation#361 for more details. Signed-off-by: Akiff Manji <akiff.manji@gmail.com>
Will enable event logging in Cloudagent Signed-off-by: Akiff Manji <akiff.manji@gmail.com>
…ptions in agents. Signed-off-by: Akiff Manji <akiff.manji@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
=======================================
Coverage 89.14% 89.14%
=======================================
Files 236 236
Lines 11222 11222
=======================================
Hits 10004 10004
Misses 1218 1218 |
|
Ran the demo and it looks good. There are still some revisions to be made to the tutorial but it's looking good. @amanji - is this ready for merging? Thanks! Updates I'm planning:
Looking good! |
|
Functionally it’s complete, but the docs need to be updated (as you mentioned). Should those changes be made first before merging? |
|
If the code is fine, I can update the docs. Easier to do after merging.
I'll do that and we can go from there.
…On Tue, Feb 18, 2020 at 4:54 AM Akiff Manji ***@***.***> wrote:
Functionally it’s complete, but the docs need to be updated (as you
mentioned). Should those changes be made first before merging?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#375>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHYRQRZ3W7X4R3HF2WRQC3RDPLBRANCNFSM4KV7M24A>
.
--
Stephen Curran
Principal, Cloud Compass Computing, Inc. (C3I)
Technical Governance Board Member - Sovrin Foundation (sovrin.org)
*Schedule a Meeting: **https://calendly.com/swcurran
<https://calendly.com/swcurran>*
|
swcurran
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds event logger to agent.py that is activated when running run_demo with the --events option.
Adds a --no-auto option to run_demo that deactivates --auto-... arguments in agent.
Updates OpenAPI demo documentation for invitation scenarios when --no-auto option is set
PR for: #361