Constantine bindings for EIP196 #184
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,10 +10,16 @@ Cargo.lock | |
|
|
||
| .gradle | ||
|
|
||
| *.DS_Store | ||
|
|
||
| ## build files | ||
| *.com | ||
| *.class | ||
| *.dll | ||
| *.exe | ||
| *.o | ||
| *.so | ||
|
|
||
| *.a | ||
| *.dylib | ||
| constantine/out | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,145 @@ | ||
| plugins { | ||
| id 'java-library' | ||
| id 'maven-publish' | ||
| id 'com.jfrog.artifactory' version '5.2.3' | ||
| } | ||
|
|
||
| repositories { | ||
| mavenCentral() | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation 'net.java.dev.jna:jna:5.12.1' | ||
| testImplementation 'com.google.guava:guava:31.1-jre' | ||
| testImplementation 'io.tmio:tuweni-bytes:2.4.2' | ||
| testImplementation 'junit:junit:4.13.2' | ||
| } | ||
|
|
||
| java { | ||
| toolchain { | ||
| languageVersion = JavaLanguageVersion.of(21) | ||
| } | ||
| } | ||
|
|
||
| tasks.withType(JavaCompile) { | ||
| options.encoding = 'UTF-8' | ||
| } | ||
|
|
||
| def osName = System.getProperty('os.name').toLowerCase() | ||
| def osArch = System.getProperty('os.arch') | ||
| def libDir | ||
|
|
||
| if (osName.contains('mac') && osArch.contains('aarch64')) { | ||
| libDir = 'darwin-aarch64' | ||
| } else if (osName.contains('mac')) { | ||
| libDir = 'darwin-x86-64' | ||
| } else if (osName.contains('linux') && osArch.contains('aarch64')) { | ||
| libDir = 'linux-gnu-aarch64' | ||
| } else { | ||
| libDir = 'linux-gnu-x86_64' | ||
| } | ||
|
|
||
| task libCopy(type: Copy) { | ||
| from "build/${libDir}/lib/" | ||
| into "build/resources/main/lib/${libDir}" | ||
| } | ||
|
|
||
| processResources.dependsOn libCopy | ||
|
|
||
| task compileJavaSource(type: Exec) { | ||
| description = 'Compiles the Java source files' | ||
| commandLine 'javac', '-d', 'build', 'src/main/java/org/hyperledger/besu/nativelib/constantine/LibConstantineEIP196.java' | ||
| dependsOn libCopy | ||
| } | ||
|
|
||
NickSneo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| tasks.named('test', Test) { | ||
| description = 'Runs the Java tests' | ||
| useJUnit { | ||
| include '**/*Test.class' | ||
| } | ||
| environment 'LD_LIBRARY_PATH', "${System.env.LD_LIBRARY_PATH}:build/resources/main/lib/${libDir}" | ||
| jvmArgs = ["-Djava.library.path=build/resources/main/lib/${libDir}"] | ||
| dependsOn compileJavaSource | ||
| } | ||
|
|
||
| jar { | ||
| archiveBaseName = 'besu-native-constantine' | ||
| includeEmptyDirs = false | ||
| manifest { | ||
| attributes( | ||
| 'Specification-Title': archiveBaseName, | ||
| 'Specification-Version': project.version, | ||
| 'Implementation-Title': archiveBaseName, | ||
| 'Implementation-Version': project.version, | ||
| 'Automatic-Module-Name': 'org.hyperledger.besu.nativelib.constantine' | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| task sourcesJar(type: Jar, dependsOn: classes) { | ||
| archiveBaseName = 'besu-native-constantine' | ||
| archiveClassifier = 'sources' | ||
| from sourceSets.main.allSource | ||
| } | ||
|
|
||
| task javadocJar(type: Jar, dependsOn: javadoc) { | ||
| archiveBaseName = 'besu-native-constantine' | ||
| archiveClassifier = 'javadoc' | ||
| from javadoc.destinationDir | ||
| } | ||
|
|
||
| publishing { | ||
| publications { | ||
| mavenJava(MavenPublication) { | ||
| groupId "org.hyperledger.besu" | ||
| artifactId 'constantine' | ||
| version "${project.version}" | ||
|
|
||
| from components.java | ||
| artifact sourcesJar | ||
| artifact javadocJar | ||
|
|
||
| pom { | ||
| name = "Besu Native - ${project.name}" | ||
| description = 'Adapter for native constantine library' | ||
| url = 'http://github.com/hyperledger/besu-native' | ||
| licenses { | ||
| license { | ||
| name = 'The Apache License, Version 2.0' | ||
| url = 'http://www.apache.org/licenses/LICENSE-2.0.txt' | ||
| } | ||
| } | ||
| scm { | ||
| connection = 'scm:git:git://github.com/hyperledger/besu-native.git' | ||
| developerConnection = 'scm:git:ssh://github.com/hyperledger/besu-native.git' | ||
| url = 'https://github.com/hyperledger/besu-native' | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| def artifactoryUser = project.hasProperty('artifactoryUser') ? project.property('artifactoryUser') : System.getenv('ARTIFACTORY_USER') | ||
| def artifactoryKey = project.hasProperty('artifactoryApiKey') ? project.property('artifactoryApiKey') : System.getenv('ARTIFACTORY_KEY') | ||
| def artifactoryRepo = System.getenv('ARTIFACTORY_REPO') ?: 'besu-maven' | ||
| def artifactoryOrg = System.getenv('ARTIFACTORY_ORG') ?: 'hyperledger' | ||
|
|
||
| artifactory { | ||
| contextUrl = "https://hyperledger.jfrog.io/${artifactoryOrg}" | ||
| publish { | ||
| repository { | ||
| repoKey = artifactoryRepo | ||
| username = artifactoryUser | ||
| password = artifactoryKey | ||
| } | ||
| defaults { | ||
| publications('mavenJava') | ||
| publishArtifacts = true | ||
| publishPom = true | ||
| } | ||
| } | ||
| } | ||
|
|
||
| test { | ||
| useJUnit() | ||
| } | ||
Submodule constantine
added at
b13816
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| #include <jni.h> | ||
| #include "ethereum_evm_precompiles.h" | ||
| #include <constantine.h> | ||
| #include <stdio.h> | ||
|
|
||
| void printByteArray(const char* label, const byte* array, size_t len) { | ||
| printf("%s: [", label); | ||
| for (size_t i = 0; i < len; i++) { | ||
| printf("%02x", array[i]); | ||
| if (i < len - 1) { | ||
| printf(", "); | ||
| } | ||
| } | ||
| printf("]\n"); | ||
| } | ||
|
|
||
| JNIEXPORT jint JNICALL Java_org_hyperledger_besu_nativelib_constantine_LibConstantineEIP196_ctt_1eth_1evm_1bn254_1g1add(JNIEnv *env, jobject obj, jbyteArray jr, jint r_len, jbyteArray jinputs, jint inputs_len) { | ||
| jbyte *r = (*env)->GetByteArrayElements(env, jr, NULL); | ||
| jbyte *inputs = (*env)->GetByteArrayElements(env, jinputs, NULL); | ||
|
|
||
| ctt_evm_status status = ctt_eth_evm_bn254_g1add((byte *)r, (ptrdiff_t)r_len, (const byte *)inputs, (ptrdiff_t)inputs_len); | ||
|
|
||
| (*env)->ReleaseByteArrayElements(env, jr, r, 0); | ||
| (*env)->ReleaseByteArrayElements(env, jinputs, inputs, 0); | ||
|
|
||
| return (jint)status; | ||
| } | ||
|
|
||
| JNIEXPORT jint JNICALL Java_org_hyperledger_besu_nativelib_constantine_LibConstantineEIP196_ctt_1eth_1evm_1bn254_1g1mul(JNIEnv *env, jobject obj, jbyteArray jr, jint r_len, jbyteArray jinputs, jint inputs_len) { | ||
| jbyte *r = (*env)->GetByteArrayElements(env, jr, NULL); | ||
| jbyte *inputs = (*env)->GetByteArrayElements(env, jinputs, NULL); | ||
|
|
||
| ctt_evm_status status = ctt_eth_evm_bn254_g1mul((byte *)r, (ptrdiff_t)r_len, (const byte *)inputs, (ptrdiff_t)inputs_len); | ||
|
|
||
| (*env)->ReleaseByteArrayElements(env, jr, r, 0); | ||
| (*env)->ReleaseByteArrayElements(env, jinputs, inputs, 0); | ||
|
|
||
| return (jint)status; | ||
| } | ||
|
|
||
| JNIEXPORT jint JNICALL Java_org_hyperledger_besu_nativelib_constantine_LibConstantineEIP196_ctt_1eth_1evm_1bn254_1pairingCheck(JNIEnv *env, jobject obj, jbyteArray jr, jint r_len, jbyteArray jinputs, jint inputs_len) { | ||
| jbyte *r = (*env)->GetByteArrayElements(env, jr, NULL); | ||
| jbyte *inputs = (*env)->GetByteArrayElements(env, jinputs, NULL); | ||
|
|
||
| ctt_evm_status status = ctt_eth_evm_bn254_ecpairingcheck((byte *)r, (ptrdiff_t)r_len, (const byte *)inputs, (ptrdiff_t)inputs_len); | ||
|
|
||
| (*env)->ReleaseByteArrayElements(env, jr, r, 0); | ||
| (*env)->ReleaseByteArrayElements(env, jinputs, inputs, 0); | ||
|
|
||
| return (jint)status; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we change the image to ubuntu-23.10 , we can install nim from apt. Looks like it is version 1.16.14 though. So maybe downloading from nim-lang is a good idea. the curl-scripted kind of installation is a supply chain attack vector though. Same could be said for the installation of rust right above it 🤔
is 1.16.14 recent enough to use or is there significant benefit to 2.0.4 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is in the final-assembly step, because I checked this step is working fine and installing nim correctly.
I see steps like these in final-assembly
I checked building with nim 2.0.4 which worked fine for me.
In constantine lib -
Constantine can be compiled by Nim v1.6.x, v2.0.2 and v2.0.4 but not Nim v2.0.0 (due to a compile-time evaluation crash)But installing with apt won't change much as even choose-nim is working fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I would expect it will work fine, but giving the contents of a URL the privilege to run anything in the shell is a really sketchy way to install dependencies. We are doing the same thing for rust, and we really shouldn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.6.x (latest is 1.6.20) works fine for Constantine and it's tested in CI. No benefits performance-wise for latest Nim versions. Constantine uses low-level Nim and has no library dependencies and even no std-lib dependencies or allocator dependencies to be extremely hard to supply-chain attack (i.e. introducing a compiler bug).
Hence the features that might justify upgrading a compiler are more related to its compile-time capabilities and type system which Constantine uses extensively.