From 1d32cb8fed89df44879194a1b3779ef69cdad813 Mon Sep 17 00:00:00 2001 From: Matthew Whitehead Date: Fri, 20 Oct 2023 17:15:03 +0100 Subject: [PATCH] Don't put NONCE_TOO_LOW transactions into the invalid nonce cache Signed-off-by: Matthew Whitehead --- .../besu/ethereum/eth/transactions/TransactionPool.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPool.java b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPool.java index c41027deb1b..3a4e8538f55 100644 --- a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPool.java +++ b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPool.java @@ -277,7 +277,12 @@ private ValidationResult addTransaction( .log(); metrics.incrementRejected( isLocal, hasPriority, validationResult.result.getInvalidReason(), "txpool"); - if (!isLocal) { + if (!isLocal + && !validationResult + .result + .getInvalidReason() + .name() + .equals(TransactionInvalidReason.NONCE_TOO_LOW.name())) { pendingTransactions.signalInvalidAndRemoveDependentTransactions(transaction); } }