Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly integration tests #1190

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

nguyer
Copy link
Contributor

@nguyer nguyer commented Feb 16, 2023

Previously we were passing the --blockchain-node flag for all integration tests. The ff init fabric subcommand does not support this flag though, so it fails to create the test stack.

Here is an example of a failed run where this happened: https://github.com/hyperledger/firefly/actions/runs/4189374980/jobs/7261623960#step:6:139

ff -v --ansi never init fabric --prometheus-enabled --database sqlite3 firefly_e2e 2 --blockchain-node fabric --token-providers erc20_erc721 --manifest ../../manifest.json --sandbox-enabled=false --multiparty=true
Error: unknown flag: --blockchain-node

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #1190 (5734b68) into main (90b46b8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1190   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          305       305           
  Lines        20057     20057           
=========================================
  Hits         20057     20057           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@awrichar awrichar merged commit 092e8c7 into hyperledger:main Feb 24, 2023
@awrichar awrichar deleted the fix-nightly-integration-tests branch February 24, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants