-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable workflows for release branch #1285
Conversation
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## release-1.2 #1285 +/- ##
===============================================
Coverage ? 100.00%
===============================================
Files ? 305
Lines ? 20027
Branches ? 0
===============================================
Hits ? 20027
Misses ? 0
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the immediate fix. I have a suggestion for a slight change that should (though untested by me) account for future release branches as well.
@@ -2,9 +2,9 @@ name: Go | |||
|
|||
on: | |||
push: | |||
branches: [main] | |||
branches: [main, release-1.2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure if we use a filter here, we could have it account for future releases as well
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#using-filters
branches: [main, release-1.2] | |
branches: [main, release-**] |
pull_request: | ||
branches: [main] | ||
branches: [main, release-1.2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branches: [main, release-1.2] | |
branches: [main, release-**] |
No description provided.