Correctly parse blockchain subscription name when delivering events #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awrichar
requested review from
peterbroadhurst,
nguyer and
shorsher
as code owners
awrichar
force-pushed
the
blockchain-ns
branch
2 times, most recently
from
d703704
to
8607d11
Compare
nguyer
suggested changes
Jul 26, 2023
internal/blockchain/common/common.go
Outdated
Comment on lines
339
to
346
| if len(subName) > UUIDLength { | ||
| uuidStart := len(subName) - UUIDLength | ||
| prefix := subName[:uuidStart-1] | ||
| listenerID := subName[uuidStart:] | ||
| if _, err := uuid.Parse(listenerID); err == nil { | ||
| parts = strings.Split(prefix, "-") | ||
| } | ||
| } |
There was a problem hiding this comment.
Namespace names are also allowed to have dashes which I think would cause problems here
This ensures the namespace can be accurately extracted. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #1378 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 315 315
Lines 22055 22061 +6
=======================================
+ Hits 22051 22057 +6
Misses 2 2
Partials 2 2
|
nguyer
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the namespace can be accurately extracted.
Fixes #1374