Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle update for unpublished API #1395

Conversation

Chengxuan
Copy link
Contributor

Update to unpublished contract APIs are no longer possible due to #1322

This PR fixes the problem by adding the upsert logic back in for unpublished contract APIs.

@Chengxuan Chengxuan requested a review from a team as a code owner September 5, 2023 13:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Merging #1395 (d27034e) into main (5418e40) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1395   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         315      315           
  Lines       22078    22093   +15     
=======================================
+ Hits        22074    22089   +15     
  Misses          2        2           
  Partials        2        2           
Files Changed Coverage Δ
internal/database/sqlcommon/contractapis_sql.go 100.00% <100.00%> (ø)
internal/definitions/handler_contracts.go 100.00% <100.00%> (ø)

Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
@Chengxuan Chengxuan reopened this Sep 12, 2023
@peterbroadhurst peterbroadhurst merged commit 145e467 into hyperledger:main Sep 13, 2023
27 checks passed
@peterbroadhurst peterbroadhurst deleted the fix-api-update-bug-for-unpublished branch September 13, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants