Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database migration order #1407

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

nguyer
Copy link
Contributor

@nguyer nguyer commented Sep 26, 2023

We've introduced a breaking change for migrations, for anyone who has used a main build since May.
This is problematic due to the timeline (even though it's main) - so addressing it:

History

  1. Separate "define" and "publish" for contract interfaces, and allow deleting unpublished interfaces #1279 merged in may - introduced 112 (ffi network name)
  2. Separate "define" and "publish" for contract APIs, and allow deleting unpublished APIs #1322 merged in may - introduced 113 (contract network name)
  3. Surface message rejection reason to API #1336 merged in june - introduced 114
  4. Replace token pool "confirmed" state with "active" bool #1305 merged in two weeks ago - duplicated 112 (rename token pool)
  5. Fix SQL migration conflict and coverage gaps #1401 moved new 112 to be 113, which moved 113->114, and 114->115

Step (5) was a problem, as existing migrations from May (113 and 114) got renamed.

Fix

This PR restores the original 113 and 114, and moves the duplicated 112 to be the latest migration at 115.

This will mean only people who created a brand new FF since #1401 merged will have an issue, which is a very recent change.

Anyone who has used a build between May and introduction of #1401 will be fine.

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer nguyer requested a review from a team as a code owner September 26, 2023 13:11
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated migration of an existing environment 👍

@peterbroadhurst peterbroadhurst merged commit 7067eb5 into hyperledger:main Sep 26, 2023
14 checks passed
@peterbroadhurst peterbroadhurst deleted the fix-migrations branch September 26, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants