Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag image as latest only when releasing the latest tag #1566

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

dwertent
Copy link
Contributor

Resolves: #1506

Signed-off-by: dwertent <david.wertenteil@kaleido.io>
@dwertent dwertent requested a review from a team as a code owner August 28, 2024 20:31
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a983877) to head (802dd18).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1566   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          325       325           
  Lines        24049     24049           
=========================================
  Hits         24049     24049           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - but e2e is failing

@dwertent
Copy link
Contributor Author

dwertent commented Aug 29, 2024

That is probably because they are flaky (I didn't change anything that could possibly affect the tests). I don't have permissions to trigger a re-run.

@dwertent
Copy link
Contributor Author

@EnriqueL8 tests passed :)

Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnriqueL8 EnriqueL8 merged commit 03fbd92 into hyperledger:main Sep 6, 2024
15 checks passed
@EnriqueL8 EnriqueL8 added this to the v1.3.2 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix latest tag in Docker image workflows
2 participants