-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tokens Tutorials #777
Conversation
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #777 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 323 323
Lines 20181 20195 +14
=========================================
+ Hits 20181 20195 +14
Continue to review full report at Codecov.
|
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
} | ||
``` | ||
|
||
## Use Metamask |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome 🔥
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested a few changes inline. Some comments may apply across multiple pages since they're all fairly similar.
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor note, but marking approved at this point. Thanks for pulling this together!
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
This PR adds two brand new tutorials for ERC-20 and ERC-721 as well as how to use Metamask with them. It also includes some updates to the ERC-1155 tutorial to include approvals.
A live preview of the new docs pages can be found at: https://nguyer.github.io/firefly/tutorials/tokens