Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tokens Tutorials #777

Merged
merged 9 commits into from
May 4, 2022
Merged

Update Tokens Tutorials #777

merged 9 commits into from
May 4, 2022

Conversation

nguyer
Copy link
Contributor

@nguyer nguyer commented Apr 29, 2022

This PR adds two brand new tutorials for ERC-20 and ERC-721 as well as how to use Metamask with them. It also includes some updates to the ERC-1155 tutorial to include approvals.

A live preview of the new docs pages can be found at: https://nguyer.github.io/firefly/tutorials/tokens

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #777 (54f3dc4) into main (ea38e01) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #777   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          323       323           
  Lines        20181     20195   +14     
=========================================
+ Hits         20181     20195   +14     
Impacted Files Coverage Δ
internal/events/aggregator.go 100.00% <0.00%> (ø)
internal/events/event_dispatcher.go 100.00% <0.00%> (ø)
internal/tokens/fftokens/fftokens.go 100.00% <0.00%> (ø)
internal/orchestrator/orchestrator.go 100.00% <0.00%> (ø)
internal/blockchain/ethereum/config.go 100.00% <0.00%> (ø)
internal/events/subscription_manager.go 100.00% <0.00%> (ø)
internal/blockchain/ethereum/ethereum.go 100.00% <0.00%> (ø)
internal/definitions/definition_handler.go 100.00% <0.00%> (ø)
internal/blockchain/ethereum/eventstream.go 100.00% <0.00%> (ø)
internal/apiserver/route_post_token_approval.go 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea38e01...54f3dc4. Read the comment docs.

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
docs/tutorials/index.md Outdated Show resolved Hide resolved
}
```

## Use Metamask
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 🔥

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Copy link
Contributor

@awrichar awrichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a few changes inline. Some comments may apply across multiple pages since they're all fairly similar.

nguyer added 2 commits May 3, 2022 14:11
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Copy link
Contributor

@awrichar awrichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor note, but marking approved at this point. Thanks for pulling this together!

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer nguyer merged commit 323eedb into hyperledger:main May 4, 2022
@nguyer nguyer deleted the tokens-docs branch May 4, 2022 12:56
This was referenced May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants