fabconnect async calls + setting broadcast/private message header types #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fabconnect default for /transactions is synchronous. The fabric plugin currently expects async responses, so adding the `x-firefly-sync` header. Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
FireFly now sets the message type for any broadcast or private messages sent via the API. Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
shorsher
requested review from
peterbroadhurst,
nguyer and
awrichar
as code owners
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #841 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 301 301
Lines 19715 19718 +3
=========================================
+ Hits 19715 19718 +3
Continue to review full report at Codecov.
|
awrichar
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two changes included in future release
1.0.2into upstream firefly.#838
#836