Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker buildx for multiarch builds #873

Merged
merged 3 commits into from
Sep 20, 2022

Conversation

nguyer
Copy link
Contributor

@nguyer nguyer commented Jun 22, 2022

This PR switches to the docker buildx command for building images for multiple CPU architectures. Currently, the build jobs are set up to build linux/amd64 and linux/arm64. This is set in the Makefile. Because building a Docker image for a non-native CPU architecture is very slow (because it's emulated), mutiarch builds are not the default when running make docker. Instead a new command, make docker-multiarch has been added, which is used by our GitHub Actions.

NOTE: From my testing docker buildx seems to return status 0, despite the fact that it may have failed to push to a repository. This can result in false positives for our GitHub Actions. I looked into this and it seems to be an open issue with buildx docker/buildx#732

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been through the scripts to check I understand, and all looks good. Shall keep an eye on the build when this merges.

@peterbroadhurst peterbroadhurst merged commit 1f31807 into hyperledger:main Sep 20, 2022
@peterbroadhurst peterbroadhurst deleted the multiarch-builds branch September 20, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants