Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SubmitNetworkAction and RootOrg config to Multiparty Manager #881

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

awrichar
Copy link
Contributor

@awrichar awrichar commented Jun 24, 2022

Also added new transaction and operation types for network action.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #881 (e1ba8b7) into main (190855f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #881   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files         299      299           
  Lines       19466    19468    +2     
=======================================
+ Hits        19462    19464    +2     
  Misses          4        4           
Impacted Files Coverage Δ
internal/identity/identitymanager.go 100.00% <100.00%> (ø)
internal/multiparty/manager.go 100.00% <100.00%> (ø)
internal/namespace/manager.go 100.00% <100.00%> (ø)
internal/networkmap/manager.go 100.00% <100.00%> (ø)
internal/networkmap/register_org.go 100.00% <100.00%> (ø)
internal/orchestrator/orchestrator.go 100.00% <100.00%> (ø)
internal/orchestrator/status.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190855f...e1ba8b7. Read the comment docs.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Copy link
Member

@shorsher shorsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, thank you!

@awrichar awrichar merged commit 52e7744 into hyperledger:main Jun 27, 2022
@awrichar awrichar deleted the multiparty branch June 27, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants