Change default contracts to network version 2 #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awrichar
requested review from
peterbroadhurst,
nguyer and
shorsher
as code owners
Codecov Report
@@ Coverage Diff @@
## main #890 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 298 298
Lines 19492 19544 +52
=======================================
+ Hits 19486 19538 +52
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
|
Based on offline discussion, might be worth also splitting the method into separate calls for batch pin / network action (but still both emitting a single shared event). Moving to draft until I can add that change. |
Also rename the "namespace" parameter to "action" in V2, and handle accordingly. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Failure to remove a subscription (ie because it was already removed) should not cause infinite retries to remove it. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
dismissed
shorsher’s stale review
Added significant new changes - needs re-review.
shorsher
approved these changes
Jul 11, 2022
jimthematrix
approved these changes
Jul 11, 2022
This was referenced Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of FIR-12
Split out separate "pinBatch" and "networkAction" methods in the V2 contract, and make it the default. Adjust the blockchain plugins to handle both versions of the contract cleanly.
Also fix some bugs found along the way with network actions being broken.