-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple copies of things on different namespaces #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Also add node description to multiparty config fields. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
requested review from
peterbroadhurst,
nguyer,
shorsher and
nickgaski
as code owners
July 30, 2022 17:35
awrichar
changed the title
Move "node" configuration to multiparty section, clean up DX operations
Allow multiple copies of things on different namespaces
Jul 30, 2022
Codecov Report
@@ Coverage Diff @@
## main #915 +/- ##
==========================================
- Coverage 99.97% 99.95% -0.02%
==========================================
Files 299 299
Lines 19487 19475 -12
==========================================
- Hits 19482 19467 -15
- Misses 4 6 +2
- Partials 1 2 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Any message, data, or definition type may get duplicated across namespaces. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
shorsher
reviewed
Aug 1, 2022
shorsher
reviewed
Aug 1, 2022
shorsher
approved these changes
Aug 1, 2022
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything that can be sent (messages, data, all definition types) needs to only be unique within a namespace. The IDs can no longer be considered globally unique, and the database needs to reflect that.
Move "node" configuration to the "multiparty" section (next to "org"), as different namespaces may want to advertise different names for their local node.
Clean up operation handling in DX to make it consistent with other plugins.