Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple copies of things on different namespaces #915

Merged
merged 9 commits into from
Aug 1, 2022

Conversation

awrichar
Copy link
Contributor

@awrichar awrichar commented Jul 30, 2022

Everything that can be sent (messages, data, all definition types) needs to only be unique within a namespace. The IDs can no longer be considered globally unique, and the database needs to reflect that.

Move "node" configuration to the "multiparty" section (next to "org"), as different namespaces may want to advertise different names for their local node.

Clean up operation handling in DX to make it consistent with other plugins.

shorsher and others added 4 commits July 30, 2022 11:39
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Also add node description to multiparty config fields.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar awrichar changed the title Move "node" configuration to multiparty section, clean up DX operations Allow multiple copies of things on different namespaces Jul 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2022

Codecov Report

Merging #915 (cc27d62) into main (8da41ac) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   99.97%   99.95%   -0.02%     
==========================================
  Files         299      299              
  Lines       19487    19475      -12     
==========================================
- Hits        19482    19467      -15     
- Misses          4        6       +2     
- Partials        1        2       +1     
Impacted Files Coverage Δ
cmd/firefly.go 100.00% <ø> (ø)
internal/coreconfig/coreconfig.go 100.00% <ø> (ø)
internal/events/event_manager.go 100.00% <ø> (ø)
pkg/core/operation.go 100.00% <ø> (ø)
internal/assets/operations.go 100.00% <100.00%> (ø)
internal/blockchain/common/common.go 100.00% <100.00%> (ø)
internal/broadcast/operations.go 100.00% <100.00%> (ø)
internal/contracts/operations.go 100.00% <100.00%> (ø)
internal/database/sqlcommon/identity_sql.go 100.00% <100.00%> (ø)
internal/dataexchange/ffdx/dxevent.go 100.00% <100.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

awrichar added 3 commits July 31, 2022 22:47
Any message, data, or definition type may get duplicated across namespaces.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar awrichar merged commit 0a31343 into hyperledger:main Aug 1, 2022
@awrichar awrichar deleted the dxoperations branch August 1, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants