add E2E test for token plugins with remote names #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorsher
requested review from
peterbroadhurst,
nguyer,
awrichar and
nickgaski
as code owners
shorsher
force-pushed
the
remote-names-tokens
branch
from
b373b11 to
6577b38
Compare
Codecov Report
@@ Coverage Diff @@
## main #920 +/- ##
==========================================
+ Coverage 99.97% 99.98% +0.01%
==========================================
Files 299 299
Lines 19481 19465 -16
==========================================
- Hits 19476 19462 -14
+ Misses 4 3 -1
+ Partials 1 0 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
awrichar
reviewed
Aug 3, 2022
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
shorsher
force-pushed
the
remote-names-tokens
branch
from
6577b38 to
ea9abec
Compare
Now the test suite will wait until the newly created namespace is available before proceeding Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
awrichar
reviewed
Aug 4, 2022
awrichar
reviewed
Aug 4, 2022
awrichar
approved these changes
Aug 4, 2022
- adds helper function for changing a plugin local name Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
|
Since this is a new runner, it may need to be added to the GitHub Workflow test matrixes for PR jobs and integration. |
|
I see the integration tests haven't been updated to even include gateway suites, so I'll file an issue |
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
shorsher
force-pushed
the
remote-names-tokens
branch
from
c45048f to
17da823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new test suite for tokens plugins with remote names.
Fixes #929