Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup of namespace comments/struct descriptions #927

Merged
merged 3 commits into from
Aug 5, 2022

Conversation

awrichar
Copy link
Contributor

@awrichar awrichar commented Aug 4, 2022

Couple of the minor follow-ups from #898

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar
Copy link
Contributor Author

awrichar commented Aug 4, 2022

Opened #929 for the test failure - going to re-run.

@shorsher
Copy link
Member

shorsher commented Aug 4, 2022

should be able to rebase once #920 is merged

@codecov-commenter
Copy link

Codecov Report

Merging #927 (33ea5b7) into main (a60dd6c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #927   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files         299      299           
  Lines       19465    19465           
=======================================
  Hits        19460    19460           
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
pkg/core/namespace.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@awrichar awrichar merged commit 92aef96 into hyperledger:main Aug 5, 2022
@awrichar awrichar deleted the nscleanup branch August 5, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants