Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin golangci-lint to v1.47.3 instead of latest #932

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

awrichar
Copy link
Contributor

@awrichar awrichar commented Aug 4, 2022

Avoids surprising changes to linter rules.

Also looks like the current "latest" version of golangci-lint is Go 1.19 only, and we don't want to upgrade just yet.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar awrichar changed the title Pin golangci-lint to v1.46.0 instead of latest Pin golangci-lint to v1.47.3 instead of latest Aug 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #932 (5d80325) into main (e903554) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #932   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files         299      299           
  Lines       19481    19483    +2     
=======================================
+ Hits        19476    19478    +2     
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
internal/blockchain/ethereum/ethereum.go 100.00% <ø> (ø)
internal/data/data_manager.go 100.00% <100.00%> (ø)
internal/dataexchange/ffdx/dxevent.go 100.00% <100.00%> (ø)
internal/dataexchange/ffdx/ffdx.go 100.00% <100.00%> (ø)
internal/definitions/handler.go 100.00% <100.00%> (ø)
internal/definitions/handler_identity_claim.go 100.00% <100.00%> (ø)
internal/definitions/sender.go 100.00% <100.00%> (ø)
internal/identity/identitymanager.go 100.00% <100.00%> (ø)
internal/networkmap/register_node.go 100.00% <100.00%> (ø)
internal/orchestrator/orchestrator.go 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@peterbroadhurst peterbroadhurst merged commit 3bce2d9 into hyperledger:main Aug 4, 2022
@peterbroadhurst peterbroadhurst deleted the golangci branch August 4, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants