Exposes docker env variables to gradle steps #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBAhire
requested review from
avinashkolluru,
buchi-busireddy and
tim-mwangi
as code owners
JBAhire
changed the title
buchi-busireddy
approved these changes
Dec 22, 2020
| run: ./gradlew dockerPushImages |
There was a problem hiding this comment.
Do we still docker login after adding env here? If, not, we can remove that in follow-up PR.
kotharironak
approved these changes
Dec 22, 2020
| @@ -67,6 +60,6 @@ jobs: | |||
| - name: Archive integration test report | |||
| uses: actions/upload-artifact@v1 | |||
| with: | |||
| name: integration-test | |||
| path: /tmp/integration-test-reports | |||
| name: test-reports | |||
There was a problem hiding this comment.
Curious (not a blocker): Why are we uploading as artifacts when we are uploading to codecov?
There was a problem hiding this comment.
codecov gives us test coverage but not test results
| @@ -33,7 +33,7 @@ jobs: | |||
| run: ./gradlew jacocoTestReport | |||
|
|
|||
| - name: Copy unit test reports | |||
| run: ./gradlew copyAllReports --output-dir=/tmp/unit-test-reports | |||
| run: ./gradlew copyAllReports --output-dir=/tmp/test-reports | |||
There was a problem hiding this comment.
this can be omitted, it's being run later
| @@ -67,6 +60,6 @@ jobs: | |||
| - name: Archive integration test report | |||
| uses: actions/upload-artifact@v1 | |||
| with: | |||
| name: integration-test | |||
| path: /tmp/integration-test-reports | |||
| name: test-reports | |||
There was a problem hiding this comment.
codecov gives us test coverage but not test results
| @@ -37,6 +37,9 @@ jobs: | |||
|
|
|||
| - name: Publish docker image | |||
| run: ./gradlew publish dockerPushImages | |||
| env: | |||
| DOCKER_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }} | |||
There was a problem hiding this comment.
write credentials should be kept distinct from read credentials (this will be a read-only token once dockerhub allows assigning permission to tokens)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
Documentation
https://github.com/hypertrace/hypertrace-gradle-docker-plugins/blob/c4cbaa615a03724c17c9eed0decf7311ac8128dc/hypertrace-gradle-docker-plugin/README.md#other-configuration