From f312110c4442d124fcdc5e1c94e7f8b37e3c684a Mon Sep 17 00:00:00 2001
From: Patricio Albizu <patricioalbizu@Patricios-MacBook-Pro.local>
Date: Mon, 2 Aug 2021 19:51:33 -0300
Subject: [PATCH] feat: removing unused type in tickCount variable

---
 package.json                                                 | 1 -
 projects/observability/package.json                          | 3 +--
 .../observability/src/shared/components/cartesian/chart.ts   | 5 ++---
 .../shared/components/cartesian/d3/axis/cartesian-axis.ts    | 3 +--
 4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/package.json b/package.json
index fbaa30728..7eac08e1b 100644
--- a/package.json
+++ b/package.json
@@ -56,7 +56,6 @@
     "d3-scale": "^3.3.0",
     "d3-selection": "^1.4.2",
     "d3-shape": "^1.3.5",
-    "d3-time": "^2.1.1",
     "d3-transition": "^1.2.0",
     "d3-zoom": "^1.8.3",
     "graphql": "^15.5.1",
diff --git a/projects/observability/package.json b/projects/observability/package.json
index 5d539eaba..ae642db84 100644
--- a/projects/observability/package.json
+++ b/projects/observability/package.json
@@ -29,8 +29,7 @@
     "d3-path": "^1.0.9",
     "d3-hierarchy": "^1.1.9",
     "d3-axis": "^1.0.12",
-    "d3-quadtree": "^1.0.6",
-    "d3-time": "^2.1.1"
+    "d3-quadtree": "^1.0.6"
   },
   "devDependencies": {
     "@hypertrace/test-utils": "^0.0.0"
diff --git a/projects/observability/src/shared/components/cartesian/chart.ts b/projects/observability/src/shared/components/cartesian/chart.ts
index b0ec073a4..e3c39c1f3 100644
--- a/projects/observability/src/shared/components/cartesian/chart.ts
+++ b/projects/observability/src/shared/components/cartesian/chart.ts
@@ -1,5 +1,4 @@
 import { TimeRange } from '@hypertrace/common';
-import { TimeInterval } from 'd3-time';
 import { LegendPosition } from '../legend/legend.component';
 import { ChartTooltipRef } from '../utils/chart-tooltip/chart-tooltip-popover';
 import { ChartEvent, ChartEventListener } from './chart-interactivty';
@@ -125,9 +124,9 @@ export interface Axis {
   max?: number;
 
   /**
-   * Determine the tick count labels (number or time interval)
+   * Determine the tick count labels
    */
-  tickCount?: number | TimeInterval;
+  tickCount?: number;
 }
 
 export interface AxisCrosshair {
diff --git a/projects/observability/src/shared/components/cartesian/d3/axis/cartesian-axis.ts b/projects/observability/src/shared/components/cartesian/d3/axis/cartesian-axis.ts
index 8339838c7..9d655e053 100644
--- a/projects/observability/src/shared/components/cartesian/d3/axis/cartesian-axis.ts
+++ b/projects/observability/src/shared/components/cartesian/d3/axis/cartesian-axis.ts
@@ -1,6 +1,5 @@
 import { Axis as D3Axis, axisBottom, AxisDomain, axisLeft, axisRight, AxisScale, axisTop } from 'd3-axis';
 import { BaseType, select, Selection } from 'd3-selection';
-import { TimeInterval } from 'd3-time';
 import { defaultsDeep } from 'lodash-es';
 import { MouseLocationData } from '../../../utils/mouse-tracking/mouse-tracking';
 import { SvgUtilService } from '../../../utils/svg/svg-util.service';
@@ -188,7 +187,7 @@ export class CartesianAxis<TData = {}> {
     }
   }
 
-  private calculateAxisTickCount(): number | TimeInterval {
+  private calculateAxisTickCount(): number {
     if (this.configuration?.tickCount !== undefined) {
       return this.configuration.tickCount;
     }