From c88b0bb13dfc33842e7b2de1f7af214f5a82e706 Mon Sep 17 00:00:00 2001 From: Jake Bassett Date: Mon, 1 Nov 2021 10:57:07 -0700 Subject: [PATCH 1/2] fix: some very minor clean up --- .../table/controls/table-controls.component.ts | 2 -- .../table/table-widget-renderer.component.ts | 16 ++++++++++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/projects/components/src/table/controls/table-controls.component.ts b/projects/components/src/table/controls/table-controls.component.ts index 1606362e0..ede10a6e3 100644 --- a/projects/components/src/table/controls/table-controls.component.ts +++ b/projects/components/src/table/controls/table-controls.component.ts @@ -102,8 +102,6 @@ import { }) export class TableControlsComponent implements OnChanges { public readonly DEFAULT_SEARCH_PLACEHOLDER: string = 'Search...'; - @Input() - public persistenceId?: string; @Input() public searchEnabled?: boolean; diff --git a/projects/observability/src/shared/dashboard/widgets/table/table-widget-renderer.component.ts b/projects/observability/src/shared/dashboard/widgets/table/table-widget-renderer.component.ts index 6dee29931..5159fa73a 100644 --- a/projects/observability/src/shared/dashboard/widgets/table/table-widget-renderer.component.ts +++ b/projects/observability/src/shared/dashboard/widgets/table/table-widget-renderer.component.ts @@ -34,7 +34,19 @@ import { Renderer } from '@hypertrace/hyperdash'; import { RendererApi, RENDERER_API } from '@hypertrace/hyperdash-angular'; import { capitalize, isEmpty, isEqual, pick } from 'lodash-es'; import { BehaviorSubject, combineLatest, Observable, of, Subject } from 'rxjs'; -import { filter, first, map, pairwise, share, startWith, switchMap, take, tap, withLatestFrom } from 'rxjs/operators'; +import { + filter, + first, + map, + mapTo, + pairwise, + share, + startWith, + switchMap, + take, + tap, + withLatestFrom +} from 'rxjs/operators'; import { AttributeMetadata, toFilterAttributeType } from '../../../graphql/model/metadata/attribute-metadata'; import { MetadataService } from '../../../services/metadata/metadata.service'; import { InteractionHandler } from '../../interaction/interaction-handler'; @@ -289,7 +301,7 @@ export class TableWidgetRendererComponent combineLatest([ this.getScope(), this.api.change$.pipe( - map(() => true), + mapTo(true), startWith(true) ) ]).pipe( From 1a81efad788000e77c6535412c21d5e5e313c746 Mon Sep 17 00:00:00 2001 From: Jake Bassett Date: Mon, 1 Nov 2021 11:11:15 -0700 Subject: [PATCH 2/2] style: prettier --- .../widgets/table/table-widget-renderer.component.ts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/projects/observability/src/shared/dashboard/widgets/table/table-widget-renderer.component.ts b/projects/observability/src/shared/dashboard/widgets/table/table-widget-renderer.component.ts index 5159fa73a..938581375 100644 --- a/projects/observability/src/shared/dashboard/widgets/table/table-widget-renderer.component.ts +++ b/projects/observability/src/shared/dashboard/widgets/table/table-widget-renderer.component.ts @@ -298,13 +298,7 @@ export class TableWidgetRendererComponent private getColumnConfigs(): Observable { return this.getPreferences().pipe( switchMap(preferences => - combineLatest([ - this.getScope(), - this.api.change$.pipe( - mapTo(true), - startWith(true) - ) - ]).pipe( + combineLatest([this.getScope(), this.api.change$.pipe(mapTo(true), startWith(true))]).pipe( switchMap(([scope]) => this.model.getColumns(scope)), startWith([]), map((columns: SpecificationBackedTableColumnDef[]) =>