From e76b60b5b41a997f3a63b0c48d1679c5b15e541a Mon Sep 17 00:00:00 2001 From: anandtiwary <52081890+anandtiwary@users.noreply.github.com> Date: Mon, 6 Dec 2021 20:36:41 -0800 Subject: [PATCH 1/2] feat: exporting field and active tab label change --- projects/observability/src/public-api.ts | 2 ++ .../span-detail/span-detail.component.ts | 14 +++++++++++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/projects/observability/src/public-api.ts b/projects/observability/src/public-api.ts index 19487cd12..030e8fbe9 100644 --- a/projects/observability/src/public-api.ts +++ b/projects/observability/src/public-api.ts @@ -97,6 +97,8 @@ export * from './shared/services/entity-breadcrumb/entity-breadcrumb.resolver'; // Span Detail export { SpanData } from './shared/components/span-detail/span-data'; export { SpanTitle } from './shared/components/span-detail/span-title'; +export { SpanDetailTab } from './shared/components/span-detail/span-detail-tab'; + export * from './shared/components/span-detail/span-detail.component'; export * from './shared/components/span-detail/span-detail.module'; export { SpanDetailLayoutStyle } from './shared/components/span-detail/span-detail-layout-style'; diff --git a/projects/observability/src/shared/components/span-detail/span-detail.component.ts b/projects/observability/src/shared/components/span-detail/span-detail.component.ts index 9ec042f26..0344d1c5d 100644 --- a/projects/observability/src/shared/components/span-detail/span-detail.component.ts +++ b/projects/observability/src/shared/components/span-detail/span-detail.component.ts @@ -24,7 +24,11 @@ import { SpanDetailTab } from './span-detail-tab'; - + = new EventEmitter(); + @Output() public readonly closed: EventEmitter = new EventEmitter(); @@ -93,4 +100,9 @@ export class SpanDetailComponent implements OnChanges { this.totalLogEvents = (this.spanData?.logEvents ?? []).length; } } + + public onActiveTabLabelChange(tabLabel: SpanDetailTab): void { + this.activeTabLabel = tabLabel; + this.activeTabLabelChange.emit(tabLabel); + } } From 8667a2924f39e0617b7e4a45ffc6c01dc32c7c90 Mon Sep 17 00:00:00 2001 From: anandtiwary <52081890+anandtiwary@users.noreply.github.com> Date: Mon, 6 Dec 2021 20:45:59 -0800 Subject: [PATCH 2/2] refactor: fixing lint errors --- .../src/shared/components/span-detail/span-detail.component.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/observability/src/shared/components/span-detail/span-detail.component.ts b/projects/observability/src/shared/components/span-detail/span-detail.component.ts index 0344d1c5d..609ff9645 100644 --- a/projects/observability/src/shared/components/span-detail/span-detail.component.ts +++ b/projects/observability/src/shared/components/span-detail/span-detail.component.ts @@ -74,7 +74,7 @@ export class SpanDetailComponent implements OnChanges { public activeTabLabel?: SpanDetailTab; @Output() - public activeTabLabelChange: EventEmitter = new EventEmitter(); + private readonly activeTabLabelChange: EventEmitter = new EventEmitter(); @Output() public readonly closed: EventEmitter = new EventEmitter();