From 8dd996b6b5660f82943eae4333a6d7951b0d1ac6 Mon Sep 17 00:00:00 2001 From: Aaron Steinfeld <45047841+aaron-steinfeld@users.noreply.github.com> Date: Tue, 21 Dec 2021 15:12:26 -0800 Subject: [PATCH] Revert "fix: grouped legend bug (#1334)" This reverts commit d5c638b837d40e96732fbe9ab15d78135bf7eab2. --- .../components/cartesian/d3/legend/cartesian-legend.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/projects/observability/src/shared/components/cartesian/d3/legend/cartesian-legend.ts b/projects/observability/src/shared/components/cartesian/d3/legend/cartesian-legend.ts index a7f000c30..5c0552862 100644 --- a/projects/observability/src/shared/components/cartesian/d3/legend/cartesian-legend.ts +++ b/projects/observability/src/shared/components/cartesian/d3/legend/cartesian-legend.ts @@ -1,7 +1,7 @@ import { ComponentRef, Injector } from '@angular/core'; import { Color, Dictionary, DynamicComponentService } from '@hypertrace/common'; import { ContainerElement, EnterElement, select, Selection } from 'd3-selection'; -import { groupBy, isEmpty } from 'lodash-es'; +import { groupBy } from 'lodash-es'; import { Observable, Subject } from 'rxjs'; import { startWith } from 'rxjs/operators'; import { LegendPosition } from '../../../legend/legend.component'; @@ -41,8 +41,7 @@ export class CartesianLegend { private readonly summaries: Summary[] = [] ) { this.isGrouped = - this.series.length > 0 && - this.series.every(seriesEntry => !isEmpty(seriesEntry.groupName) && seriesEntry.groupName !== seriesEntry.name); + this.series.length > 0 && this.series.every(seriesEntry => seriesEntry.groupName !== seriesEntry.name); this.groupedSeries = this.isGrouped ? groupBy(this.series, seriesEntry => seriesEntry.groupName) : {}; this.activeSeries = [...this.series];