Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI inconsistency in Group menu sub-items #4179

Open
lyzadanger opened this issue Feb 4, 2022 · 3 comments
Open

UI inconsistency in Group menu sub-items #4179

lyzadanger opened this issue Feb 4, 2022 · 3 comments
Labels

Comments

@lyzadanger
Copy link
Contributor

lyzadanger commented Feb 4, 2022

There's an inconsistency in the hover behavior for sub-menu items in the groups menu in the client. The group-activity item is a link and is getting different cursor hover styling than the other items, which are not links.

submenu-items

The link has the default pointer style, which is correct. The actions do not, and they should also have the pointer style.

Expected

When I hover over an action, I get a pointer- styled cursor.

@lyzadanger lyzadanger added the bug label Feb 4, 2022
@chrisshaw
Copy link

@lyzadanger doesn't this actually make sense? One is an action. One is a link. What does our design language say about action buttons versus link buttons?

If anything, this seems like a complex case of a Link within a List Item component within an Accordian List pattern. And I don't see anything that would define how we handle that in the design system. But I do see link, and I do see button.

We can of course create whatever rules of meaning we want. If it's more usable to make them consistent let's do it. But I think this may actually follow common conventions to have the link styled differently.

@lyzadanger
Copy link
Contributor Author

I'd like to have cursor:pointer on the actions if nothing else.

@chrisshaw
Copy link

Yeah that makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants