Set full height to orderable table header buttons #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the students table in LMS's dashboard, I realized the header was sometimes not fully "clickable" close to the cell edges.
After a bit of investigation I have realized that, depending on the site's font size, the button which is rendering the order icon can be slightly taller than the rest of buttons, causing this issue.
That is not reproducible in this page, but it is in LMS, due to the smaller base font size.
cells-2024-04-26_14.34.29.mp4
This PR adds
h-fullto the header buttons, to make sure they all span to the height of the taller one.