Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookie set crash on newer versions of express #151

Merged
merged 1 commit into from
Jul 1, 2018

Conversation

codinronan
Copy link
Contributor

In Express 4, this field is called headersSent so this module is throwing exceptions on that platform.

https://github.com/expressjs/express/blob/master/History.md#400--2014-04-09

In Express 4, this field is called `headersSent` so this module is throwing exceptions on that platform.

https://github.com/expressjs/express/blob/master/History.md#400--2014-04-09
@jamuhl jamuhl merged commit 09f1a03 into i18next:master Jul 1, 2018
@jamuhl
Copy link
Member

jamuhl commented Jul 1, 2018

published in i18next-express-middleware@1.2.0

@jamuhl
Copy link
Member

jamuhl commented Jul 1, 2018

Thank you for contributing a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants