Remove Express alias of res.setHeader #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2019
|
thank you - published in i18next-express-middleware@1.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #191 (comment), it appears we can support non-Express use with connect and
httpsby simply removing these two Expressres.setcalls. Theres.setalias is identical to the vanillares.setHeader.This PR should be completely transparent to existing users, but will allow new users to opt out of Express.
It should be noted that due to lack of test coverage in this repo, there may indeed be other Express syntax problems that we have not discovered yet. Future bug reports by non-Express users may reveal these sorts of problems.
Also - we might at some point want to change the naming here to just
i18next-middleware?