Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unique key warning on componentized element #1835

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

rothsandro
Copy link
Contributor

Fixes the unique key warning that occurs with React 19 when the Trans component was used with elements with children. The created Componentized element didn't include the original key.

Fixes #1834

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@adrai adrai merged commit f8068d3 into i18next:master Feb 18, 2025
8 checks passed
@coveralls
Copy link

Coverage Status

coverage: 95.797%. remained the same
when pulling 8250d5d on rothsandro:bugfix/componentized-key
into 330a8e7 on i18next:master.

@adrai
Copy link
Member

adrai commented Feb 18, 2025

included in v15.4.1
thx for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Trans /> with gives unique key warning for components with children (React 19)
3 participants