Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleHeater: no need for targetTemperatureDivisor #467

Open
lisanet opened this issue May 13, 2024 · 0 comments · May be fixed by #468
Open

SimpleHeater: no need for targetTemperatureDivisor #467

lisanet opened this issue May 13, 2024 · 0 comments · May be fixed by #468
Assignees
@iRayanKhan
Labels
bug Something isn't working

Comments

@lisanet
Copy link

lisanet commented May 13, 2024

In SimpleHeater there's no need for targetTemperatureDivisor.

Instead just use _getDividedState()

This should also make configuration more clearly, beacaus it's not very obvious what the difference is between targetTemperatureDivisor and thersholdTemperatureDivisor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iRayanKhan iRayanKhan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@lisanet @iRayanKhan