Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle target widget type in stacked widget #1043

Merged
merged 4 commits into from
Aug 5, 2021

Conversation

hiqua
Copy link
Collaborator

@hiqua hiqua commented Aug 1, 2021

Fixes #965.

@hiqua hiqua mentioned this pull request Aug 1, 2021
2 tasks
@hiqua hiqua force-pushed the 965_illegal_state_exception branch from 7aa9462 to 4947ad0 Compare August 1, 2021 16:31
@hiqua
Copy link
Collaborator Author

hiqua commented Aug 1, 2021

I get a

W/System.err: org.isoron.uhabits.core.models.HabitNotFoundException
        at org.isoron.uhabits.widgets.BaseWidgetProvider.getHabitsFromWidgetId(BaseWidgetProvider.kt:115)
        at org.isoron.uhabits.widgets.TargetWidgetProvider.getWidgetFromId(TargetWidgetProvider.kt:25)
        at org.isoron.uhabits.widgets.BaseWidgetProvider.update(BaseWidgetProvider.kt:149)
        at org.isoron.uhabits.widgets.BaseWidgetProvider.onUpdate$lambda-0(BaseWidgetProvider.kt:107)
        at org.isoron.uhabits.widgets.BaseWidgetProvider.lambda$OH7e88rsKqRhrOgJe55zIFJRuuA(BaseWidgetProvider.kt)
        at org.isoron.uhabits.widgets.-$$Lambda$BaseWidgetProvider$OH7e88rsKqRhrOgJe55zIFJRuuA.run(lambda)
        at java.lang.Thread.run(Thread.java:818)

as of 4947ad0 when I create a new widget. Not sure if it's due to my changes, but trying to fix this anyway.

Edit: looks fine as of e06e014, but I'm wondering if there's still something missing with the initialization. Sometimes, restarting the AVD results in the widget not being populated until I open the app. Maybe that's another issue.

@hiqua hiqua marked this pull request as ready for review August 1, 2021 17:34
@hiqua hiqua requested a review from iSoron August 1, 2021 17:34
Copy link
Owner

@iSoron iSoron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down, @hiqua! Since these changes are for Loop 2.0.3, could you please submit this PR against branch hotfix/2.0.3 instead of dev? There may be a few conflicts because of d0ef749.

@hiqua hiqua changed the base branch from dev to hotfix/2.0.3 August 3, 2021 06:17
@hiqua hiqua force-pushed the 965_illegal_state_exception branch from e06e014 to a9c133f Compare August 3, 2021 06:30
@hiqua hiqua force-pushed the 965_illegal_state_exception branch from a9c133f to 91ff5f7 Compare August 3, 2021 06:38
@hiqua hiqua requested a review from iSoron August 3, 2021 08:25
@iSoron iSoron merged commit e756a63 into iSoron:hotfix/2.0.3 Aug 5, 2021
@iSoron
Copy link
Owner

iSoron commented Aug 5, 2021

@hiqua Looks good, thanks! I could not reproduce the issue of the widgets being blank after reboot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IllegalStateException in StackRemoteViewsFactory.constructWidget
2 participants