From a4ca5b76616e6ca904b8256cacac123232684c3f Mon Sep 17 00:00:00 2001
From: ftoromanoff <francois.toromanoff@ign.fr>
Date: Mon, 11 Mar 2024 15:44:26 +0100
Subject: [PATCH] refactor(review): put urls on 2 lines

---
 test/unit/entwine.js            |  5 +++--
 test/unit/geoidlayer.js         |  3 ++-
 test/unit/orientedimagelayer.js | 11 +++++++----
 test/unit/source.js             |  3 ++-
 4 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/test/unit/entwine.js b/test/unit/entwine.js
index 8052b216af..84d7271e3c 100644
--- a/test/unit/entwine.js
+++ b/test/unit/entwine.js
@@ -12,8 +12,9 @@ import Renderer from './bootstrap';
 import ept from '../data/entwine/ept.json';
 import eptHierarchy from '../data/entwine/ept-hierarchy/0-0-0-0.json';
 
-const urlEpt = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/pointclouds/entwine/ept.json';
-const urlEptHierarchy = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/pointclouds/entwine/ept-hierarchy/0-0-0-0.json';
+const baseurl = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/pointclouds';
+const urlEpt = `${baseurl}/entwine/ept.json`;
+const urlEptHierarchy = `${baseurl}/entwine/ept-hierarchy/0-0-0-0.json`;
 
 const resources = {
     [urlEpt]: ept,
diff --git a/test/unit/geoidlayer.js b/test/unit/geoidlayer.js
index b5eadd0185..ad76fca779 100644
--- a/test/unit/geoidlayer.js
+++ b/test/unit/geoidlayer.js
@@ -30,7 +30,8 @@ describe('GlobeView', function () {
         stubSuppFetcher.withArgs('application/gtx')
             .callsFake(() => () => Promise.resolve(buffer));
 
-        const url = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/altitude-conversion-grids/RAF20_float.gtx';
+        const url = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/' +
+            'altitude-conversion-grids/RAF20_float.gtx';
 
         const geoidSource = new FileSource({
             url,
diff --git a/test/unit/orientedimagelayer.js b/test/unit/orientedimagelayer.js
index 81a5919928..27b81656f5 100644
--- a/test/unit/orientedimagelayer.js
+++ b/test/unit/orientedimagelayer.js
@@ -11,8 +11,9 @@ import Renderer from './bootstrap';
 import panoData from '../data/OrientedImage/panoramicsMetaDataParis.geojson';
 import camCalibration from '../data/OrientedImage/cameraCalibration.json';
 
-const orientationsUrl = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/immersive/exampleParis1/panoramicsMetaDataParis.geojson';
-const calibrationUrl = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/immersive/exampleParis1/cameraCalibration.json';
+const baseurl = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/immersive';
+const orientationsUrl = `${baseurl}/exampleParis1/panoramicsMetaDataParis.geojson`;
+const calibrationUrl = `${baseurl}/exampleParis1/cameraCalibration.json`;
 
 const resources = {
     [orientationsUrl]: panoData,
@@ -45,10 +46,12 @@ describe('Oriented Image Layer', function () {
         const orientedImageSource = new OrientedImageSource({
             url: 'http://www.itowns-project.org/itowns-sample-data-small/images/140616/Paris-140616_0740-{cameraId}-00001_0000{panoId}.jpg',
             // Url to a GEOJSON file describing feature points. It describes position and orientation of each panoramic.
-            orientationsUrl: 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/immersive/exampleParis1/panoramicsMetaDataParis.geojson',
+            orientationsUrl: 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/' +
+                'immersive/exampleParis1/panoramicsMetaDataParis.geojson',
             // Url of a a JSON file with calibration for all cameras. see [CameraCalibrationParser]{@link module:CameraCalibrationParser.parse}
             // in this example, we have the ladybug, it's a set of 6 cameras
-            calibrationUrl: 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/immersive/exampleParis1/cameraCalibration.json',
+            calibrationUrl: 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/' +
+                'immersive/exampleParis1/cameraCalibration.json',
         });
 
         // Create oriented image layer
diff --git a/test/unit/source.js b/test/unit/source.js
index 12be34c8d0..50a1208315 100644
--- a/test/unit/source.js
+++ b/test/unit/source.js
@@ -325,7 +325,8 @@ describe('Sources', function () {
         });
 
         it('should instance C3DTilesSource', function (done) {
-            const url3dTileset = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/3DTiles/lyon_1_4978/tileset.json';
+            const url3dTileset = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/' +
+                '3DTiles/lyon_1_4978/tileset.json';
             const source = new C3DTilesSource({ url: url3dTileset });
             source.whenReady
                 .then(() => {