Skip to content

Commit

Permalink
refactor(review): put urls on 2 lines
Browse files Browse the repository at this point in the history
  • Loading branch information
ftoromanoff committed Mar 13, 2024

Unverified

This user has not yet uploaded their public signing key.
1 parent 94a407e commit f5e81ad
Showing 4 changed files with 14 additions and 8 deletions.
5 changes: 3 additions & 2 deletions test/unit/entwine.js
Original file line number Diff line number Diff line change
@@ -12,8 +12,9 @@ import Renderer from './bootstrap';
import ept from '../data/entwine/ept.json';
import eptHierarchy from '../data/entwine/ept-hierarchy/0-0-0-0.json';

const urlEpt = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/pointclouds/entwine/ept.json';
const urlEptHierarchy = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/pointclouds/entwine/ept-hierarchy/0-0-0-0.json';
const baseurl = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/pointclouds';
const urlEpt = `${baseurl}/entwine/ept.json`;
const urlEptHierarchy = `${baseurl}/entwine/ept-hierarchy/0-0-0-0.json`;

const resources = {
[urlEpt]: ept,
3 changes: 2 additions & 1 deletion test/unit/geoidlayer.js
Original file line number Diff line number Diff line change
@@ -30,7 +30,8 @@ describe('GlobeView', function () {
stubSuppFetcher.withArgs('application/gtx')
.callsFake(() => () => Promise.resolve(buffer));

const url = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/altitude-conversion-grids/RAF20_float.gtx';
const url = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/' +
'altitude-conversion-grids/RAF20_float.gtx';

const geoidSource = new FileSource({
url,
11 changes: 7 additions & 4 deletions test/unit/orientedimagelayer.js
Original file line number Diff line number Diff line change
@@ -11,8 +11,9 @@ import Renderer from './bootstrap';
import panoData from '../data/OrientedImage/panoramicsMetaDataParis.geojson';
import camCalibration from '../data/OrientedImage/cameraCalibration.json';

const orientationsUrl = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/immersive/exampleParis1/panoramicsMetaDataParis.geojson';
const calibrationUrl = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/immersive/exampleParis1/cameraCalibration.json';
const baseurl = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/immersive';
const orientationsUrl = `${baseurl}/exampleParis1/panoramicsMetaDataParis.geojson`;
const calibrationUrl = `${baseurl}/exampleParis1/cameraCalibration.json`;

const resources = {
[orientationsUrl]: panoData,
@@ -45,10 +46,12 @@ describe('Oriented Image Layer', function () {
const orientedImageSource = new OrientedImageSource({
url: 'http://www.itowns-project.org/itowns-sample-data-small/images/140616/Paris-140616_0740-{cameraId}-00001_0000{panoId}.jpg',
// Url to a GEOJSON file describing feature points. It describes position and orientation of each panoramic.
orientationsUrl: 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/immersive/exampleParis1/panoramicsMetaDataParis.geojson',
orientationsUrl: 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/' +
'immersive/exampleParis1/panoramicsMetaDataParis.geojson',
// Url of a a JSON file with calibration for all cameras. see [CameraCalibrationParser]{@link module:CameraCalibrationParser.parse}
// in this example, we have the ladybug, it's a set of 6 cameras
calibrationUrl: 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/immersive/exampleParis1/cameraCalibration.json',
calibrationUrl: 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/' +
'immersive/exampleParis1/cameraCalibration.json',
});

// Create oriented image layer
3 changes: 2 additions & 1 deletion test/unit/source.js
Original file line number Diff line number Diff line change
@@ -325,7 +325,8 @@ describe('Sources', function () {
});

it('should instance C3DTilesSource', function (done) {
const url3dTileset = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/3DTiles/lyon_1_4978/tileset.json';
const url3dTileset = 'https://raw.githubusercontent.com/iTowns/iTowns2-sample-data/master/' +
'3DTiles/lyon_1_4978/tileset.json';
const source = new C3DTilesSource({ url: url3dTileset });
source.whenReady
.then(() => {

0 comments on commit f5e81ad

Please sign in to comment.