From 78b1ad7d20b296ea41d0601d243d1584e900dacf Mon Sep 17 00:00:00 2001 From: Jean Tampon Date: Wed, 11 Sep 2024 04:33:56 -0700 Subject: [PATCH] Adds windows configuration to VS code tasks (#963) # Description Currently, the tasks shipped with the VS code configuration only specify Linux commands, which prevent the use of them on Windows. This MR adds those tasks for Windows OS as well. Fixes #962 ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --- .vscode/tasks.json | 6 ++++++ CONTRIBUTORS.md | 1 + 2 files changed, 7 insertions(+) diff --git a/.vscode/tasks.json b/.vscode/tasks.json index 59dcc3d859..f7896a038b 100644 --- a/.vscode/tasks.json +++ b/.vscode/tasks.json @@ -9,6 +9,9 @@ "type": "shell", "linux": { "command": "${workspaceFolder}/isaaclab.sh -p ${workspaceFolder}/.vscode/tools/setup_vscode.py" + }, + "windows": { + "command": "${workspaceFolder}/isaaclab.bat -p ${workspaceFolder}/.vscode/tools/setup_vscode.py" } }, { @@ -17,6 +20,9 @@ "type": "shell", "linux": { "command": "${workspaceFolder}/isaaclab.sh --format" + }, + "windows": { + "command": "${workspaceFolder}/isaaclab.bat --format" } } ] diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index f4e7c09cd1..64d787a376 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -41,6 +41,7 @@ Guidelines for modifications: * Chenyu Yang * David Yang * HoJin Jeon +* Jean Tampon * Jia Lin Yuan * Jingzhou Liu * Johnson Sun