fix: wrong ordinal for fr local

[R3tep]

This pull request fix a wrong ordinal definition for fr local.

[codecov]

Codecov Report

Merging #1932 (ef0561d) into dev (7b4a99c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev     #1932   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          181       181           
  Lines         2064      2064           
  Branches       538       538           
=========================================
  Hits          2064      2064           

Impacted Files	Coverage Δ
src/locale/fr.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4a99c...ef0561d. Read the comment docs.

[iamkun]

Is fr locale's ordinal different under different format tokens?

ref https://github.com/moment/moment/blob/develop/src/locale/fr.js#L82

[R3tep]

The fr locale can change whether the grammatical gender is masculine or feminine.

This only affects numbers equal to 1.

The masculine grammatical gender is 1er.
The feminine grammatical gender is 1re.

But for a number greater than 1, it is always suffixed by e like 11e

[iamkun]

Thanks, let's get this merged

[iamkun]

🎉 This PR is included in version 1.11.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[xavier-villelegier]

Hey @R3tep, why this change ? In french when it's the 1st of July for exemple we say "1er juillet 2022", but for the 2nd, we never write "2e juillet 2022" or "3e juillet 2022". This might be correct mathematically speaking, but not in term of dates ? What was your use case ?

cc @iamkun

[CBD-iBiZa]

@xavier-villelegier

Hey @R3tep, why this change ? In french when it's the 1st of July for exemple we say "1er juillet 2022", but for the 2nd, we never write "2e juillet 2022" or "3e juillet 2022". This might be correct mathematically speaking, but not in term of dates ? What was your use case ?

cc @iamkun

For week of year, with ordinal (wo format), the output in french is not correct.

• 1st (week) => 1re (semaine), not 1er (semaine)
• 2nd (week) => 2e (semaine), not 2 (semaine)
• 3rd (week) => 3e (semaine), not 3 (semaine)
• ...

It was perfectly ok in Moment, not with DayJS+WeekOfYear plugin.