Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with adding/subtracting durations from Dayjs objects #1156

Merged
merged 5 commits into from
Oct 21, 2020
Merged

Fix issues with adding/subtracting durations from Dayjs objects #1156

merged 5 commits into from
Oct 21, 2020
+21 −9

Commits on Oct 21, 2020

  1. fix: add typescript typings for add/subtract of durations

    @mfogel
    mfogel committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    8922b8f View commit details
    Browse the repository at this point in the history

  2. fix: support passing duration to subtract()

    @mfogel
    mfogel committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    f810b61 View commit details
    Browse the repository at this point in the history

  3. refactor: simplify argument transformation

    @mfogel
    mfogel committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    26ee8f6 View commit details
    Browse the repository at this point in the history

  4. fix: unit is an optional arg for add() and subtract()

    @mfogel
    mfogel committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    379f348 View commit details
    Browse the repository at this point in the history

  5. fix: revert types docs to not mentioning default value

    @mfogel
    mfogel committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    d3e94af View commit details
    Browse the repository at this point in the history