Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.3: Improve and extend the security checklist #2571

Merged
merged 6 commits into from
Dec 6, 2024
Merged

3.3: Improve and extend the security checklist #2571

merged 6 commits into from
Dec 6, 2024

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Dec 5, 2024 •
edited
Loading

Question Answer
JIRA Ticket N/A
Versions 3.3
Edition All

#2565 for 3.3

1fd6457 fully overrides the previous version.

Let's check if there is something not backward compatible.

Preview: https://ez-systems-developer-documentation--2571.com.readthedocs.build/en/2571/guide/security_checklist/

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@glye @adriendupuis
Improve and extend the security checklist (#2565)
1fd6457 
---------

Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com>
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>

(cherry picked from commit 270e2e3)
@adriendupuis adriendupuis requested a review from glye December 5, 2024 14:21
glye
glye approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, when the powered-by fix is committed.

docs/guide/security_checklist.md Outdated Show resolved Hide resolved
@adriendupuis
security_checklist.md: Fix internal link
9a016a5 
Fix `AutoLinksPlugin unable to find install_ibexa_dxp.md` error
@adriendupuis
security_checklist.md: ibexa_system_info → ezplatform_support_tools
5d92d29 
Backward to the old name for 3.3
@adriendupuis adriendupuis requested a review from glye December 6, 2024 09:23
glye
glye approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with the "strings" change. Thanks!

@adriendupuis @glye
security_checklist.md: Fix grammar
a2fa5c8 
Remove remaining plural from previous change

Co-authored-by: Gunnstein Lye <289744+glye@users.noreply.github.com>
@adriendupuis adriendupuis merged commit c57e08c into 3.3 Dec 6, 2024
3 of 4 checks passed
@adriendupuis adriendupuis deleted the improve_security_checklist-3.3 branch December 6, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glye glye glye approved these changes

Assignees
No one assigned
Labels
Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriendupuis @glye