Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code_samples_usage.php: Handle --8<-- syntax #2578

Merged
merged 1 commit into from
Dec 11, 2024
Merged

code_samples_usage.php: Handle --8<-- syntax #2578

merged 1 commit into from
Dec 11, 2024

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Dec 11, 2024 •
edited
Loading

Question Answer
JIRA Ticket N/A
Versions master, 4.6
Edition N/A

Handle the --8<-- file inclusion syntax
See test at #2577 (comment)

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis mentioned this pull request Dec 11, 2024
Closed
7 tasks
@adriendupuis adriendupuis marked this pull request as ready for review December 11, 2024 08:07
@adriendupuis adriendupuis requested a review from mnocon December 11, 2024 08:12
mnocon
mnocon approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! At some point it might be good to add basic end to end tests for this file - to make sure it remains maintanable over time.

@mnocon mnocon mentioned this pull request Dec 11, 2024
Merged
7 tasks
@adriendupuis adriendupuis merged commit 3c096b1 into master Dec 11, 2024
5 of 6 checks passed
@adriendupuis adriendupuis deleted the enh-code-samples-usage branch December 11, 2024 13:43
adriendupuis added a commit that referenced this pull request Dec 11, 2024
@adriendupuis
code_samples_usage.php: Handle --8<-- syntax (#2578)
1f29bdd 
(cherry picked from commit 3c096b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon approved these changes

Assignees
No one assigned
Labels
Needs DOC review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriendupuis @mnocon