IBX-8335: Initial integration with API Platform #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
force-pushed
the
IBX-8335-full-api-platform
branch
2 times, most recently
from
ae550d9
to
3b250ed
Compare
tischsoic
force-pushed
the
IBX-8335-full-api-platform
branch
from
fb103f5
to
40cff86
Compare
tischsoic
force-pushed
the
IBX-8335-full-api-platform
branch
from
b161278
to
50f6a84
Compare
|
konradoboza
reviewed
Sep 26, 2024
Comment on lines
+19
to
+21
| /** | ||
| * @var array<string> | ||
| */ |
There was a problem hiding this comment.
We tend to use one-liner here.
| /** | ||
| * @internal | ||
| */ | ||
| final class ClassNameResourceNameCollectionFactory implements ResourceNameCollectionFactoryInterface |
Comment on lines
+19
to
+21
| private readonly OpenApiFactoryInterface $decorated, | ||
| private readonly SchemasCollectionFactory $schemaCollectionFactory, | ||
| private readonly KernelInterface $kernel, |
There was a problem hiding this comment.
Cannot the whole class be readonly instead?
| } | ||
|
|
||
| $responses = $operation->getResponses(); | ||
|
|
| * @var int $responseCode | ||
| * @var \ApiPlatform\OpenApi\Model\Response|array<string, array<mixed>> $response | ||
| */ | ||
| foreach ($operation->getResponses() as $responseCode => $response) { |
There was a problem hiding this comment.
Suggested change
| foreach ($operation->getResponses() as $responseCode => $response) { | |
| foreach ($responses as $responseCode => $response) { |
| index_1: '@ibexa.api_platform.ibexa_openapi.factory' | ||
|
|
||
| ibexa.api_platform.ibexa_openapi.factory: | ||
| class: 'Ibexa\Bundle\Rest\ApiPlatform\OpenApiFactory' |
There was a problem hiding this comment.
Suggested change
| class: 'Ibexa\Bundle\Rest\ApiPlatform\OpenApiFactory' | |
| class: Ibexa\Bundle\Rest\ApiPlatform\OpenApiFactory |
Comment on lines
+13
to
+14
|
|
||
|
|
|
|
||
|
|
||
| # Collecting schemas | ||
|
|
|
|
||
| namespace Ibexa\Rest\ApiPlatform; | ||
|
|
||
| final class SchemasCollection implements \IteratorAggregate, \Countable |
There was a problem hiding this comment.
Suggested change
| final class SchemasCollection implements \IteratorAggregate, \Countable | |
| final readonly class SchemasCollection implements \IteratorAggregate, \Countable |
| use Symfony\Component\HttpKernel\KernelInterface; | ||
| use Symfony\Component\Yaml\Yaml; | ||
|
|
||
| final class SchemasProvider implements SchemasProviderInterface |
There was a problem hiding this comment.
Readonly class instead of all properties?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Merge after Symfony 6 introduction in the DXP
Description:
Initial API Platform core integration with Language endpoint specification as an example.
Installation
Because we have not moved from Symfony 5.4 to a higher version, fork of
api-platform/corewith dependencies downgraded to Symfony 5.4 (and related likepsretc) is needed.This fork can be found here (branch
downgraded-deps): https://github.com/tischsoic/core/tree/downgraded-depsAnd diff of changes can be found here: tischsoic/core@69b4d35...tischsoic:core:downgraded-deps
My setup of the
composer.jsonfrom the project root:Because of inconsistencies between. PHP version in different packages composer needs to ignore PHP version requirement:
composer update --ignore-platform-req=phpFor QA:
Documentation: