-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8470: Upgraded codebase to Symfony 6 #138
Open
alongosz
wants to merge
10
commits into
main
Choose a base branch
from
ibx-8470-symfony-6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
ibx-8470-symfony-6
branch
from
November 20, 2024 13:40
1d152c6
to
9ef1d00
Compare
Quality Gate passedIssues Measures |
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This is a part of bigger set of changes, to be merged together when ready
Related PRs:
Description:
This PR bumps Symfony to v6 with necessary codebase upgrades.
Please take a look at
RestAuthenticator
changes.getPassword
method is completely gone fromUserInterface
, without any replacement, so not sure what will be end result of that change. Temporarily placed empty string there.I'll need to go back to REST Functional tests once full-stack app is upgraded.
Key changes:
QA:
Sanities in the form of regression tests.
Documentation:
No documentation required.