Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8470: Upgraded codebase to Symfony 6 #138

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Nov 20, 2024

Caution

This is a part of bigger set of changes, to be merged together when ready

  • Remove TMP commits before merge
🎫 Issue IBX-8470

Related PRs:

Description:

This PR bumps Symfony to v6 with necessary codebase upgrades.

Please take a look at RestAuthenticator changes. getPassword method is completely gone from UserInterface, without any replacement, so not sure what will be end result of that change. Temporarily placed empty string there.

I'll need to go back to REST Functional tests once full-stack app is upgraded.

Key changes:

  • [Composer] Dropped obsolete ci-scripts from dev requirements
  • Bumped Symfony packages requirements to ^6.4
  • Dropped Symfony Container dependency from REST base controller
  • Dropped Symfony Container dependency from Content controller
  • [Security] Aligned RestAuthenticator with Symfony 6
  • Improved Controllers code quality
  • Aligned SessionController with Symfony 6
  • [PHPStan] Removed resolved issues from the baseline
  • [Tests] Aligned VisitorTest with Symfony 6

QA:

Sanities in the form of regression tests.

Documentation:

No documentation required.

@alongosz alongosz marked this pull request as ready for review November 20, 2024 13:36
Copy link

sonarcloud bot commented Nov 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants