IBX-5135: Added LocationDepth and IsMainLocation criterion parsers

[Steveb-p]

Question	Answer
JIRA issue	IBX-5135
Type	improvement/feature
Target version	v4.4
BC breaks	no
Tests pass	yes
Doc needed	yes

This PR adds missing parsers for LocationDepth and IsMainLocation criterions.

Example IsMainLocation:

{
  "ViewInput": {
    "identifier": "TitleView",
    "Query": {
      "LocationFilter": {
        "IsMainLocation": 1
      },
      "limit": 10,
      "offset": 0
    }
  }
}

Example LocationDepth:

{
  "ViewInput": {
    "identifier": "TitleView",
    "Query": {
      "LocationFilter": {
        "LocationDepth": {
          "Value": [1],
          "Operator": "eq"
        }
      },
      "limit": 10,
      "offset": 0
    }
  }
}

TODO:

• Implement tests.
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[tomaszszopinski]

Hello, @Steveb-p , please have a look at these queries:

For LocationDepth:

{
    "ViewInput": {
        "identifier": "TitleView",
        "Query": {
            "LocationFilter": {
                "LocationDepth": {
                    "Value": 
                        3
                    ,
                    "Operator": "eq"
                }
            },
            "limit": 300,
            "offset": 0
        }
    }
}

and

{
    "ViewInput": {
        "identifier": "TitleView",
        "Query": {
            "LocationFilter": {
                "LocationDepth": {
                    "Value": 
                        1
                    ,
                    "Operator": "eq"
                }
            },
            "limit": 300,
            "offset": 0
        }
    }
}

For isMainLocation:

{
    "ViewInput": {
        "identifier": "TitleView",
        "Query": {
            "LocationFilter": {
                "IsMainLocation": "asdf"
            }
            ,
            "limit": 30,
            "offset": 0
        }
    }
}

and

{
    "ViewInput": {
        "identifier": "TitleView",
        "Query": {
            "LocationFilter": {
                "IsMainLocation": 1
            }
            ,
            "limit": 30,
            "offset": 0
        }
    }
}

Returned output is the same, seems like criterions dont work as expected.

[tomaszszopinski]

Also, for. the same queries run on elasticSearch im getting no items found. Example :
Input

{
    "ViewInput": {
        "identifier": "title",
        "Query": {
            "LocationFilter": {
                "LocationDepth": {
                    "Value": 
                       2
                    ,
                    "Operator": "eq"
                }
            },
            "limit": 300,
            "offset": 0
        }
    }
}

Output:

{
    "View": {
        "_media-type": "application/vnd.ibexa.api.View+json",
        "_href": "/api/ibexa/v2/views/title",
        "identifier": "title",
        "Query": {
            "_media-type": "application/vnd.ibexa.api.Query+json"
        },
        "Result": {
            "_media-type": "application/vnd.ibexa.api.ViewResult+json",
            "_href": "/api/ibexa/v2/views/title/results",
            "count": 0,
            "time": null,
            "timedOut": false,
            "maxScore": null,
            "searchHits": {
                "searchHit": []
            },
            "aggregations": []
        }
    }
}

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[adamwojs]

@Steveb-p I guess this PR could back to QA, am I right?

[Steveb-p]

@adamwojs we never figured out why exactly there is a discrepancy on the criteria, and the result they give. I suspect they are not working correctly in their base implementation, and REST responses probably are incorrect because of it.

[papcio122]

Looks like the key 'LocationFilter' from the request is not used anywhere in the code.
Shouldn't 'LocationQuery' be used instead of 'Query' in the request and then just 'Filter' instead of 'LocationFilter'?