Skipped generating solrconfig.xml file copies in generate-solr-config.sh

[adamwojs]

Question	Answer
JIRA issue	N/A
Type	bug
Target Ibexa version	v4.5
BC breaks	no

Skipped generating solrconfig.xml file copies in bin/generate-solr-config.sh: solrconfig.xml.bak and solrconfig.xml.bak2

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly (main for features, the oldest supported for bugs).
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review (ping for example @ibexa/php-dev for back-end changes and/or @ibexa/javascript-dev for front-end changes).

[mnocon]

I'm not sure about this one, I think it was made this way to make it work on OSX as well (https://stackoverflow.com/questions/4247068/sed-command-with-i-option-failing-on-mac-but-works-on-linux)

[adamwojs]

Then we should clean up backup files after sed command 😉

[alongosz]

I'm not sure about this one, I think it was made this way to make it work on OSX as well (https://stackoverflow.com/questions/4247068/sed-command-with-i-option-failing-on-mac-but-works-on-linux)

Interesting... Maybe then sed -i''?
Or use good version of sed:

brew install gnu-sed
alias sed=gsed

[alongosz]

But on the other hand this should be used by CI only. Can we actually move to docker when trying to run this on local machines? That CI automation ran locally has its disadvantages.

[mnocon]

But on the other hand this should be used by CI only. Can we actually move to docker when trying to run this on local machines? That CI automation ran locally has its disadvantages.

It's mentioned directly in the Platform.sh configuration files:
https://github.com/ibexa/post-install/blob/main/resources/platformsh/ibexa-commerce/4.6.x-dev/.platform/services.yaml#L54-L58

and can be run by partners - I don't think they will see your comment about gnu-sed 😛

[alongosz]

But on the other hand this should be used by CI only. Can we actually move to docker when trying to run this on local machines? That CI automation ran locally has its disadvantages.

It's mentioned directly in the Platform.sh configuration files: https://github.com/ibexa/post-install/blob/main/resources/platformsh/ibexa-commerce/4.6.x-dev/.platform/services.yaml#L54-L58

and can be run by partners - I don't think they will see your comment about gnu-sed 😛

Meh :)
I thought it was for CI only. Nvm then.

[webhdx]

Maybe we should just recommend installing and aliasing sed? This could be a requirement. sed is a commonly used tool.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[adamwojs]

Now backup copies are automatically removed. Merging.