test(duckdb): add test for chunk_size param in to_pyarrow_batches #10480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
cpcloud
requested changes
Nov 13, 2024
| "age": np.random.randint(20, 70, size=500000), | ||
| } | ||
| ) | ||
| batches = t.to_pyarrow_batches(chunk_size=100_000) |
There was a problem hiding this comment.
Suggested change
| batches = t.to_pyarrow_batches(chunk_size=100_000) | |
| batches = con.to_pyarrow_batches(t, chunk_size=100_000) |
You need to use con here, otherwise you'll implicitly set the default backend, which is what's currently causing CI to fail.
There was a problem hiding this comment.
I'll absolutely change it! When does using the table implicitly set the default backend?
There was a problem hiding this comment.
Whenever you don't explicitly use a backend instance like con. Something has to do the compute, and if you haven't specified that thing explicitly by constructing a backend instance and then using it, or by calling ibis.set_backend(<some backend instance>) then Ibis is going to pick the default backend (DuckDB).
cpcloud
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added test to finish off #10445