Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency sqlglot to v26 #10570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 11, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sqlglot >=23.4,<25.35 -> >=23.4,<26.1 age adoption passing confidence

Release Notes

tobymao/sqlglot (sqlglot)

v26.0.0

Compare Source

💥 BREAKING CHANGES
✨ New Features
🐛 Bug Fixes

v25.34.1

Compare Source

💥 BREAKING CHANGES
✨ New Features
🔧 Chores

Configuration

📅 Schedule: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Issues or PRs related to dependencies label Dec 11, 2024
@renovate renovate bot force-pushed the renovate/sqlglot-26.x branch from 004eece to 5981e08 Compare December 11, 2024 07:43
@IndexSeek
Copy link
Member

It seems that the mssql temporal tests are running into trouble after tobymao/sqlglot@ab10851.

The timestamp_col is now an UnknownColumn.

Would the fix for this be to add this mapping

    typecode.DATETIME2: dt.Timestamp,
    typecode.SMALLDATETIME: dt.Timestamp,

to

_from_sqlglot_types = {

Here are some quick references to those types for MSSQL:

https://learn.microsoft.com/en-us/sql/t-sql/data-types/smalldatetime-transact-sql?view=sql-server-ver16
https://learn.microsoft.com/en-us/sql/t-sql/data-types/datetime2-transact-sql?view=sql-server-ver16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or PRs related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant