Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Add non-nullable info to schema output #2117

Merged
merged 1 commit into from
Mar 17, 2020
Merged

FEAT: Add non-nullable info to schema output #2117

merged 1 commit into from
Mar 17, 2020

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Mar 5, 2020

Resolves #2115

@xmnlab xmnlab changed the title Add non-nullable info to schema output. FEAT: Add non-nullable info to schema output. Mar 5, 2020
@xmnlab xmnlab changed the title FEAT: Add non-nullable info to schema output. FEAT: Add non-nullable info to schema output Mar 5, 2020
@xmnlab
Copy link
Contributor Author

xmnlab commented Mar 5, 2020

It seems the error

   ValueError: Incompatible component merge:
      - 'cp38'
      - '*_cp38'

was already fixed. maybe in 1 hour or more it would be available.

@xmnlab
Copy link
Contributor Author

xmnlab commented Mar 5, 2020

conda-forge/python-feedstock#325

@xmnlab xmnlab mentioned this pull request Mar 6, 2020
Merged
@xmnlab xmnlab added the feature Features or general enhancements label Mar 6, 2020
@xmnlab xmnlab mentioned this pull request Mar 7, 2020
Closed
@xmnlab xmnlab requested a review from jreback March 10, 2020 16:00
@xmnlab
Copy link
Contributor Author

xmnlab commented Mar 10, 2020

@jreback this PR is ready for review. thanks!

jreback
jreback suggested changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is ok to change, but pls make a release note.

ibis/expr/datatypes.py Show resolved Hide resolved
@xmnlab
Copy link
Contributor Author

xmnlab commented Mar 12, 2020

release note added and ci green.

@jreback jreback added this to the Next Feature Release milestone Mar 14, 2020
@jreback
Copy link
Contributor

jreback commented Mar 14, 2020

lgtm. pls resolve conflicts and ping on green.

@xmnlab
Copy link
Contributor Author

xmnlab commented Mar 15, 2020

thanks for the review @jreback ! ci is green :)

@jreback jreback merged commit cad629e into ibis-project:master Mar 17, 2020
@jreback
Copy link
Contributor

jreback commented Mar 17, 2020

thanks @xmnlab

@xmnlab xmnlab deleted the show-non-nullable branch December 21, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
feature Features or general enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema output doesn't show if the field is non-nullable
2 participants
@xmnlab @jreback