Change uses of BGRA for images to RGBA and use image-rs 0.24 #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there a reason this was using BGRA? RGBA is more common, though BGR was historically popular at one point. `image` 0.24 has removed support for BGR images. `image::Handle::from_pixels()` is renamed to `image::Handle::from_rgba()` to be more descriptive, and force any users to use RGBA instead of silently interpreting their pixels incorrectly.
ids1024
force-pushed
the
rgba
branch
2 times, most recently
from
87cb37d to
ce0a242
Compare
|
Updated to fix svg rendering (by removing the RGBA -> BGRA conversion, so this is an improvement). Apparently wgpu only guarantees |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a reason this was using BGRA? RGBA is more common, though BGR was historically popular at one point.
image0.24 has removed support for BGR images.image::Handle::from_pixels()is renamed toimage::Handle::from_rgba()to be more descriptive, and force any users to use RGBA instead of silently interpreting their pixels incorrectly.