Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
Custom
variant to every style available in the built-inTheme
. These new variants take a boxedStyleSheet
of the widget with aTheme
style. This allows for complete customization on a case-by-case basis of any widget without the need to implement a custom theme, which has quite the steep entry barrier.For instance, the
Button
style is defined now as follows:Thus, any user using the built-in
Theme
can implement now a custombutton::StyleSheet
and have full control over the appearance of aButton
. For example:And then you can use it on any
Button
:Basically, this PR satisfies all of the use cases of our previous styling approach (before #1362 landed) while still encouraging a first-class theme with consistent styling.