#58 control tokens for android by gradle properties

icerockdev · Jul 7, 2021 · f2554d5 · f2554d5
1 parent b27aae2
commit f2554d5
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/sample/android-app/build.gradle.kts b/sample/android-app/build.gradle.kts
@@ -14,6 +14,13 @@ android {
         versionName = "0.1.0"
 
         multiDexEnabled = true
+
+        val googleMapsApiKey: String = (extra["googleMaps.apiKey"] as? String).orEmpty()
+        val mapboxPublicToken: String = (extra["mapbox.publicToken"] as? String).orEmpty()
+
+        manifestPlaceholders["googleMapsApiKey"] = googleMapsApiKey
+        buildConfigField("String", "GOOGLE_MAPS_API_KEY", "\"$googleMapsApiKey\"")
+        buildConfigField("String", "MAPBOX_PUBLIC_TOKEN", "\"$mapboxPublicToken\"")
     }
 }
 

diff --git a/sample/android-app/src/main/AndroidManifest.xml b/sample/android-app/src/main/AndroidManifest.xml
@@ -22,7 +22,6 @@
         <activity android:name=".GoogleMapsActivity" />
         <activity android:name=".MapboxActivity" />
 
-        <!-- TODO: Replace with your API Key from https://developers.google.com/maps/documentation/ios-sdk/ -->
-        <meta-data android:name="com.google.android.geo.API_KEY" android:value="YOUR-API-KEY"/>
+        <meta-data android:name="com.google.android.geo.API_KEY" android:value="${googleMapsApiKey}"/>
     </application>
 </manifest>
diff --git a/sample/android-app/src/main/java/com/icerockdev/app/GoogleMapsActivity.kt b/sample/android-app/src/main/java/com/icerockdev/app/GoogleMapsActivity.kt
@@ -27,8 +27,7 @@ class GoogleMapsActivity : MvvmActivity<ActivityGoogleMapsBinding, GoogleMapView
                     applicationContext = applicationContext
                 ),
                 googleMapController = GoogleMapController(
-                    // TODO: Replace with your API Key from https://developers.google.com/maps/documentation/android-sdk/
-                    geoApiKey = "YOUR-API-KEY"
+                    geoApiKey = BuildConfig.GOOGLE_MAPS_API_KEY
                 )
             ).apply { start() }
         }

diff --git a/sample/android-app/src/main/java/com/icerockdev/app/MapboxActivity.kt b/sample/android-app/src/main/java/com/icerockdev/app/MapboxActivity.kt
@@ -21,7 +21,7 @@ class MapboxActivity : MvvmActivity<ActivityMapboxBinding, MapboxViewModel>() {
     override val viewModelVariableId: Int = BR.viewModel
     override val viewModelClass: Class<MapboxViewModel> = MapboxViewModel::class.java
 
-    private val mapboxToken = "YOUR-ACCESS-TOKEN"
+    private val mapboxToken = BuildConfig.MAPBOX_PUBLIC_TOKEN
 
     override fun viewModelFactory(): ViewModelProvider.Factory {
         return createViewModelFactory {