Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove viewModelScope protection #206

Closed
casvanluijtelaar opened this issue Sep 30, 2022 · 2 comments · Fixed by #212
Closed

Remove viewModelScope protection #206

casvanluijtelaar opened this issue Sep 30, 2022 · 2 comments · Fixed by #212
Labels
enhancement New feature or request
Milestone
0.15.0

Comments

@casvanluijtelaar
Copy link

casvanluijtelaar commented Sep 30, 2022 •
edited
Loading

Is there a specific reason why viewModelScope is protected in your implementation? it prevents us from adding our own extensions similar to this.
@idan-fido
Copy link
Contributor

idan-fido commented Oct 31, 2022 •
edited
Loading

+1 needed extension fun

@idan-fido idan-fido mentioned this issue Oct 31, 2022
Merged
@Alex009 Alex009 linked a pull request Nov 1, 2022 that will close this issue
Remove viewModelScope protection #212
Merged
@Alex009 Alex009 added this to the 0.15.0 milestone Nov 1, 2022
@Alex009 Alex009 added the enhancement New feature or request label Nov 1, 2022
@Alex009
Copy link
Member

Alex009 commented Nov 1, 2022

will be available in 0.15.0 release

@Alex009 Alex009 closed this as completed Nov 1, 2022
@Alex009 Alex009 mentioned this issue Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Remove viewModelScope protection
3 participants
@Alex009 @casvanluijtelaar @idan-fido