Prevent memory churn described in #208 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing `stateFlow.value` is not guaranteed to always return the same instance even when the underlying value is unchanged. This stateFlow behavior was incorrectly causing infinite `objectWillChange` events due to the equality test always reporting `false` even when the new value was, in fact, equal to the previous. The fix is to go through [`isEqual(to:)`](https://developer.apple.com/documentation/foundation/nsarray/1411770-isequal) to compare the value _contents_ when determine equality before firing off an `objectWillChange` event.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@kramlex check this please |
kramlex
reviewed
Nov 26, 2022
darronschall
force-pushed
the
patch-1
branch
from
53603ea to
7a021e9
Compare
kramlex
approved these changes
Dec 1, 2022
|
@Alex009 check this pr please |
Alex009
approved these changes
Dec 18, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
darronschall
added a commit
to darronschall/moko-mvvm
that referenced
this pull request
Mar 16, 2024
This applies the same change made to `state` in icerockdev#209 to `stateNullable` to prevent potential memory churn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208
Accessing
stateFlow.valueis not guaranteed to always return the same instance even when the underlying value is unchanged. This stateFlow behavior was incorrectly causing infiniteobjectWillChangeevents due to the equality test always reportingfalseeven when the new value was, in fact, equal to the previous.The fix is to go through
isEqual(to:)to compare the value contents to determine equality before firing off anobjectWillChangeevent.